Skip to content

docs: fix Redundant "See also:" link in ContentChild #28334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jithil-kore wants to merge 1 commit into from
Closed

docs: fix Redundant "See also:" link in ContentChild #28334

jithil-kore wants to merge 1 commit into from

Conversation

@jithil-kore
Copy link
Contributor

@jithil-kore jithil-kore commented Jan 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
This changes removed Redundant "See also:" link in ContentChild Page. Which will re render the same page on click,

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently if the "See also:" link in ContentChild page will re render the ContentChild page again.

Issue Number: #28318

What is the new behavior?

The See Also link has been removed from the ContentChild Page.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jithil-kore jithil-kore requested review from a team January 24, 2019 10:45
@jithil-kore jithil-kore force-pushed the content-child-doc-patch branch from b107f49 to 8def278 Compare January 24, 2019 10:46
@jithil-kore jithil-kore mentioned this pull request Jan 24, 2019
Closed
@petebacondarwin petebacondarwin added area: core Issues related to the framework runtime comp: docs/api labels Jan 24, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@brandonroberts brandonroberts self-assigned this Jan 24, 2019
@brandonroberts
Copy link
Contributor

brandonroberts commented Jan 24, 2019

Thanks for the PR @jithil-kore! Will you rebase this down to a single commit?

@brandonroberts brandonroberts added comp: docs effort1: hours action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Jan 24, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 24, 2019
@brandonroberts brandonroberts changed the title Content child doc patch docs: fix Redundant "See also:" link in ContentChild Jan 24, 2019
@jenniferfell
Copy link
Contributor

jenniferfell commented Jan 25, 2019 •
edited
Loading

@jithil-kore : I also noticed that one commit has completely unrelated changes (yarn version upgrade), which should be in a separate PR. I believe that squashing the commits per @brandonroberts request, that will also resolve this issue and remove the yarn version changes from this PR. Thanks!

@jithil-kore jithil-kore force-pushed the content-child-doc-patch branch 2 times, most recently from 0ebca36 to f8c5bc7 Compare January 25, 2019 04:27
@jithil-kore
Copy link
Contributor Author

jithil-kore commented Jan 25, 2019

@brandonroberts I have rebased the PR to single commit.

And as @jenniferfell suggested, making separate PR for the package update.

@jithil-kore jithil-kore mentioned this pull request Jan 25, 2019
Closed
14 tasks
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 25, 2019
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 25, 2019
@petebacondarwin
Copy link
Contributor

petebacondarwin commented Jan 25, 2019

This needs super level docs review from @jenniferfell - then we can apply merge label.

@jithil-kore
Copy link
Contributor Author

jithil-kore commented Jan 29, 2019

This needs super level docs review from @jenniferfell - then we can apply merge label.

@jenniferfell, could you please review this PR.

@brandonroberts brandonroberts added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2019
@brandonroberts
Copy link
Contributor

brandonroberts commented Jan 29, 2019

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit.

@jasonaden jasonaden force-pushed the content-child-doc-patch branch from f8c5bc7 to 6fdb268 Compare January 29, 2019 20:03
@jasonaden jasonaden closed this in dabcb3e Jan 29, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
@jithil-kore @jasonaden
docs: fix Redundant "See also:" link in ContentChild (#28334)
7c15778 
PR Close #28334
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@jithil-kore @vetom
docs: fix Redundant "See also:" link in ContentChild (angular#28334)
156f4c1 
PR Close angular#28334
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brandonroberts brandonroberts brandonroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brandonroberts brandonroberts

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@jithil-kore @brandonroberts @jenniferfell @petebacondarwin @googlebot